Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that ping_interval should be >= wait_timeout #373

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

anarthal
Copy link
Collaborator

Fix defect in connection_pool docs

close #290

Fix defect in connection_pool docs

close #290
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (eba723f) to head (f987fbf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #373   +/-   ##
========================================
  Coverage    99.04%   99.04%           
========================================
  Files          143      143           
  Lines         7157     7157           
========================================
  Hits          7089     7089           
  Misses          68       68           
Files with missing lines Coverage Δ
include/boost/mysql/connection_pool.hpp 100.00% <ø> (ø)
include/boost/mysql/pool_params.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba723f...f987fbf. Read the comment docs.

@anarthal anarthal merged commit fe5b27d into develop Oct 14, 2024
6 checks passed
@anarthal anarthal deleted the feature/290-ping-interval-docs branch October 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that pool_params::ping_interval should be greater than wait_timeout
1 participant