Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with_diagnostics now passes through unknown signatures #377

Merged
merged 8 commits into from
Nov 2, 2024

Conversation

anarthal
Copy link
Collaborator

@anarthal anarthal commented Nov 2, 2024

This makes asio::as_tuple and asio::redirect_error usable as partial completion tokens with any_connection and connection_pool.
Removed leftover comment in the pipeline example.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (272533c) to head (a044e96).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #377   +/-   ##
========================================
  Coverage    99.04%   99.05%           
========================================
  Files          143      143           
  Lines         7157     7161    +4     
========================================
+ Hits          7089     7093    +4     
  Misses          68       68           
Files with missing lines Coverage Δ
include/boost/mysql/impl/with_diagnostics.hpp 100.00% <100.00%> (ø)
include/boost/mysql/with_diagnostics.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272533c...a044e96. Read the comment docs.

@anarthal anarthal merged commit 8b2727f into develop Nov 2, 2024
6 checks passed
@anarthal anarthal deleted the feature/with-diagnostics-as-tuple branch November 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant