Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ping_interval docs regarding its relation with wait_timeout #392

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

anarthal
Copy link
Collaborator

@anarthal anarthal commented Jan 1, 2025

close #391

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (41597b7) to head (85b79d0).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #392   +/-   ##
========================================
  Coverage    98.95%   98.95%           
========================================
  Files          142      142           
  Lines         7186     7186           
========================================
  Hits          7111     7111           
  Misses          75       75           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41597b7...85b79d0. Read the comment docs.

@anarthal anarthal marked this pull request as ready for review January 3, 2025 10:37
@anarthal anarthal merged commit 25f9900 into develop Jan 3, 2025
6 checks passed
@anarthal anarthal deleted the bugfix/391-ping-interval-docs branch January 3, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ping_interval docs
1 participant