-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes zoidberg #3054
Merged
Merged
Fixes zoidberg #3054
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
18ded81
CI: Install zoidberg and new versions
dschwoerer ceb51f5
DEBUG: monkey patch zoidberg
dschwoerer 5050fd0
Remove x-boundary
dschwoerer c9c4a5a
Specify MXG=1
dschwoerer bc052cc
use MXG from grid file
dschwoerer 21ea39f
Remove debug statement
dschwoerer 67f1da3
Remove python2 compat
dschwoerer dc9047d
Prefer get with default value
dschwoerer 48f0a36
CI: Try limiting multithreading
dschwoerer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
Jinja2~=3.1.4 | ||
numpy~=2.0.0 | ||
scipy>=1.11.0 | ||
netcdf4~=1.7.1 | ||
Jinja2>=3.1.4 | ||
numpy>=2.0.0 | ||
scipy>=1.14.1 | ||
netcdf4>=1.7.1 | ||
matplotlib>=3.7.0 | ||
Cython~=3.0.0 | ||
boututils~=0.2.1 | ||
boutdata~=0.2.1 | ||
Cython>=3.0.0 | ||
boututils>=0.2.1 | ||
boutdata>=0.2.1 | ||
zoidberg>=0.2.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,16 +29,20 @@ mthread = 2 | |
directory = "data" | ||
|
||
with DataFile("grid.fci.nc") as grid: | ||
xfwd = grid.read("forward_xt_prime")[1:-1] | ||
xbwd = grid.read("backward_xt_prime")[1:-1] | ||
try: | ||
MXG = grid.read("MXG") | ||
except: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should have explicit exception to catch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the review - all fixed! |
||
MXG = 1 | ||
xfwd = grid.read("forward_xt_prime")[MXG:-MXG] | ||
xbwd = grid.read("backward_xt_prime")[MXG:-MXG] | ||
|
||
nx = xfwd.shape[0] | ||
|
||
regions = { | ||
"xin_fwd": xfwd < 1, | ||
"xout_fwd": xfwd > nx, | ||
"xin_bwd": xbwd < 1, | ||
"xout_bwd": xbwd > nx, | ||
"xin_fwd": xfwd < MXG, | ||
"xout_fwd": xfwd > nx + MXG - 1, | ||
"xin_bwd": xbwd < MXG, | ||
"xout_bwd": xbwd > nx + MXG - 1, | ||
} | ||
regions = {k: v.astype(int) for k, v in regions.items()} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left-in debugging?