revert: remove background for non-resizable textboxes

This commit reverts 3e487b4
bpmn-io · Apr 23, 2024 · 998b37a · 998b37a
1 parent 833fdb8
commit 998b37a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/lib/TextBox.js b/lib/TextBox.js
@@ -120,8 +120,10 @@ TextBox.prototype.create = function(bounds, style, value, options) {
     minHeight: bounds.minHeight + 'px',
     left: bounds.x + 'px',
     top: bounds.y + 'px',
+    backgroundColor: '#ffffff',
     position: 'absolute',
     overflow: 'visible',
+    border: '1px solid #ccc',
     boxSizing: 'border-box',
     wordWrap: 'normal',
     textAlign: 'center',
@@ -166,11 +168,6 @@ TextBox.prototype.create = function(bounds, style, value, options) {
   }
 
   if (options.resizable) {
-    assign(parent.style, {
-      backgroundColor: '#ffffff',
-      border: '1px solid #ccc'
-    });
-
     this.resizable(style);
   }
 

diff --git a/test/DirectEditingSpec.js b/test/DirectEditingSpec.js
@@ -551,10 +551,8 @@ describe('diagram-js-direct-editing', function() {
 
         // then
         var resizeHandle = directEditing._textbox.parent.getElementsByClassName('djs-direct-editing-resize-handle')[0];
-        var parent = directEditing._textbox.parent;
 
         expect(resizeHandle).to.exist;
-        expect(parent.getAttribute('style').indexOf('background-color:')).not.to.eql(-1);
       }));
 
 
@@ -573,10 +571,8 @@ describe('diagram-js-direct-editing', function() {
 
         // then
         var resizeHandle = directEditing._textbox.parent.getElementsByClassName('djs-direct-editing-resize-handle')[0];
-        var parent = directEditing._textbox.parent;
 
         expect(resizeHandle).not.to.exist;
-        expect(parent.getAttribute('style').indexOf('background-color:')).to.eql(-1);
       }));