Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Symfony 7 support #52

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

mRoca
Copy link
Contributor

@mRoca mRoca commented Jun 14, 2024

Fixes #49

Nothing changed in the src dir, except removing of sf4 dedicated blocs.

I've updated some dev vendors, but --prefer-lowest deps are still not usable, especially because of bentools/doctrine-static old doctrine requirement (I've added some Doctrine\Common\Persistence old interfaces stubs in order to keep using it).

@bpolaszek
Copy link
Owner

Very good job @mRoca !
Regarding bentools/doctrine-static, there are probably more common / modern ways to tackle Doctrine tests now - we could either use an Sqlite database or just mock Doctrine.
Do you fancy doing this? If that's too much work, tell me and we'll address this later.

@mRoca
Copy link
Contributor Author

mRoca commented Jun 17, 2024

Hi @bpolaszek, I totally agree with you, but it would indeed imply spending too much time for this PR. IMHO, the best option would be using Doctrine with in-memory sqlite db, but it should maybe be the point of another PR.

@mRoca
Copy link
Contributor Author

mRoca commented Jun 25, 2024

@bpolaszek I've just added a WebPushBundle::build: void in order to avoid the following log:

deprecation.INFO: User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "BenTools\WebPushBundle\WebPushBundle" now to avoid errors or add an explicit @return annotation to suppress this message at vendor/symfony/error-handler/DebugClassLoader.php:337)"} []

@rcournault
Copy link

@bpolaszek Why not merge this Pull Request ?

@bpolaszek bpolaszek merged commit c279c5a into bpolaszek:master Jul 15, 2024
3 checks passed
@bpolaszek
Copy link
Owner

Thank you @mRoca ! 🙏

@mRoca mRoca deleted the chore/sf7 branch July 15, 2024 12:07
@rcournault
Copy link

@bpolaszek Thank you ! Can you create a release / version / tag plz ? Can you do a realesed so I can update my project with composer ?

@bpolaszek
Copy link
Owner

I'd like to embed this one in the release, meanwhile you can composer req bentools/webpush-bundle:dev-master#c279c5a.

On Github, subscribe to the releases of this repository and you'll be notified as soon as a new version pops up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Symfony 7.0
3 participants