Revert "Revert "disable autostop when set""

This reverts commit 49a417e.

.github/workflows/Test_CanClonePublicRepoWithoutAuthorizeddKeysAllFormats.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_CanClonePublicRepoWithoutAuthorizeddKeysAllFormats$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_ChangePwd.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_ChangePwd$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_CustomBranchCustomSetupCustomFolder.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_CustomBranchCustomSetupCustomFolder$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_NoProjectBrev.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_NoProjectBrev$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_NoUserBrevNoProj.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_NoUserBrevNoProj$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_NoUserBrevProj.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_NoUserBrevProj$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_ProjectRepoNoBrev.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_ProjectRepoNoBrev$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_ProvidedSetupFileChange.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_ProvidedSetupFileChange$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_ProvidedSetupRanNoProj.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_ProvidedSetupRanNoProj$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_ProvidedSetupUpdated.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_ProvidedSetupUpdated$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_UnauthenticatedSSHKey.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_UnauthenticatedSSHKey$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_UserBrevProjectBrevV0.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_UserBrevProjectBrevV0$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_UserBrevProjectBrevV1All.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_UserBrevProjectBrevV1All$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_UserBrevProjectBrevV1Minimal.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_UserBrevProjectBrevV1Minimal$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_VscodeExtension.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_VscodeExtension$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/Test_httpGit.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: go test -timeout 240s -run ^Test_httpGit$ github.com/brevdev/brev-cli/e2etest/setup

.github/workflows/build.yml

@@ -23,6 +23,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
+          cache: true
 
       - name: Build
         run: make fast-build

.github/workflows/fmt.yml

@@ -23,6 +23,8 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
+          cache: true
+
 
       - name: install
         run: make install

.github/workflows/legacy.yml

@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: Build
         run: make ci
       - name: Upload coverage
@@ -63,6 +63,6 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: Release test
         run: make build

.github/workflows/lint.yml

@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: install
         run: make install
       - name: lint
@@ -33,6 +33,6 @@ jobs:
         uses: ravsamhq/notify-slack-action@v1
         with:
           status: ${{ job.status }}
-          notify_when: 'failure'
+          notify_when: "failure"
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}

.github/workflows/release.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: Release
         run: make ci smoke-test release
         env:

.github/workflows/test.yml

@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: install
         run: make install
       - name: test
@@ -50,6 +50,6 @@ jobs:
         uses: ravsamhq/notify-slack-action@v1
         with:
           status: ${{ job.status }}
-          notify_when: 'failure'
+          notify_when: "failure"
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}

.github/workflows/vet.yml

@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
-
+          cache: true
       - name: install
         run: make install
       - name: vet
@@ -33,6 +33,6 @@ jobs:
         uses: ravsamhq/notify-slack-action@v1
         with:
           status: ${{ job.status }}
-          notify_when: 'failure'
+          notify_when: "failure"
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}

bin/gen-e2e-actions.py

@@ -28,7 +28,7 @@ def generate_file_content(test_name):
       - uses: actions/setup-go@v2
         with:
           go-version: 1.18
-      - name: expire test cache
+          cache: true      - name: expire test cache
         run: go clean -testcache
       - name: test
         run: """

pkg/autostartconf/autostartconf.go

@@ -237,27 +237,44 @@ User=` + store.GetOSUser() + `
 
 func NewBrevMonConfigure(
 	store AutoStartStore,
+	disableAutostop bool,
 ) DaemonConfigurer {
-	return AptBinaryConfigurer{
-		LinuxSystemdConfigurer: LinuxSystemdConfigurer{
-			Store: store,
-			ValueConfigFile: `
-[Unit]
+	configFile := `[Unit]
 Description=brevmon
 After=network.target
 
 [Service]
 User=root
 Type=exec
-ExecStart=/usr/local/bin/brevmon
+ExecStart=
 ExecReload=/usr/local/bin/brevmon
 Restart=always
 
 [Install]
 WantedBy=default.target
-`,
-			ServiceName: "brevmon.service",
-			ServiceType: "system",
+`
+	if disableAutostop {
+		configFile = `[Unit]
+Description=brevmon
+After=network.target
+
+[Service]
+User=root
+Type=exec
+ExecStart=
+ExecReload=/usr/local/bin/brevmon --disable-autostop
+Restart=always
+
+[Install]
+WantedBy=default.target
+`
+	}
+	return AptBinaryConfigurer{
+		LinuxSystemdConfigurer: LinuxSystemdConfigurer{
+			Store:           store,
+			ValueConfigFile: configFile,
+			ServiceName:     "brevmon.service",
+			ServiceType:     "system",
 		},
 
 		URL:  "https://s3.amazonaws.com/brevmon.brev.dev/brevmon.tar.gz",

pkg/cmd/envsetup/envsetup.go

@@ -83,6 +83,7 @@ func NewCmdEnvSetup(store envsetupStore, noLoginStore nologinEnvStore) *cobra.Co
 					token,
 					noLoginStore,
 					datadogAPIKey,
+					disableAutostop,
 				)
 				if err != nil {
 					errors = multierror.Append(err)
@@ -111,6 +112,7 @@ func RunEnvSetup(
 	workspaceid, token string,
 	noLoginStore nologinEnvStore,
 	datadogAPIKey string,
+	disableAutostop bool,
 ) error {
 	if token != "" {
 		err := noLoginStore.LoginWithToken(token)
@@ -156,6 +158,7 @@ func RunEnvSetup(
 		params,
 		configureSystemSSHConfig,
 		datadogAPIKey,
+		disableAutostop,
 	)
 	if err != nil {
 		return breverrors.WrapAndTrace(err)
@@ -451,13 +454,14 @@ func newEnvIniter(
 	configureSystemSSHConfig bool,
 	store envsetupStore,
 	datadogAPIKey string,
+	disableAbleAUtosop bool,
 ) *envInitier {
 	workspaceIniter := setupworkspace.NewWorkspaceIniter(user.HomeDir, user, params)
 
 	return &envInitier{
 		*workspaceIniter,
 		configureSystemSSHConfig,
-		autostartconf.NewBrevMonConfigure(store),
+		autostartconf.NewBrevMonConfigure(store, disableAbleAUtosop),
 		datadogAPIKey,
 		store,
 	}
@@ -468,6 +472,7 @@ func setupEnv(
 	params *store.SetupParamsV0,
 	configureSystemSSHConfig bool,
 	datadogAPIKey string,
+	disableAutoStop bool,
 ) error {
 	err := store.BuildBrevHome()
 	if err != nil {
@@ -483,6 +488,7 @@ func setupEnv(
 		configureSystemSSHConfig,
 		store,
 		datadogAPIKey,
+		disableAutoStop,
 	)
 	// set logfile path to ~/.brev/envsetup.log
 	logFilePath := filepath.Join(user.HomeDir, ".brev", "envsetup.log")

pkg/cmd/postinstall/postinstall.go

@@ -97,7 +97,7 @@ func Runpostinstall(
 		return breverrors.WrapAndTrace(err)
 	}
 
-	brevmonConfigurer := autostartconf.NewBrevMonConfigure(store)
+	brevmonConfigurer := autostartconf.NewBrevMonConfigure(store, false)
 
 	err = brevmonConfigurer.Install()
 	if err != nil {