Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh proxy support #204

Merged
merged 6 commits into from
Oct 17, 2024
Merged

ssh proxy support #204

merged 6 commits into from
Oct 17, 2024

Conversation

tmonty12
Copy link
Contributor

@tmonty12 tmonty12 commented Oct 16, 2024

PR downloads the Cloudflare Binary when the refresh command is ran. If a workspace has the ProxyHostname field for SSH or HostSSH, the config is written to use the Cloudflared ProxyCommand instead of the VM hostname.

I tested that the Cloudflared binary was successfully downloaded on Linux and Mac Arm64. Also tested that workspace with Proxy successfully used ProxyCommand and could make SSH Proxy connection.

Copy link
Member

@theFong theFong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/store/cloudflared.go Outdated Show resolved Hide resolved
@tmonty12 tmonty12 merged commit 9501426 into main Oct 17, 2024
4 of 7 checks passed
@tmonty12 tmonty12 deleted the ssh-proxy-support branch October 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants