arithmetic internals: Further clarify bn_mul_mont ABI. #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 96.74% 96.74% -0.01%
==========================================
Files 171 171
Lines 20853 20853
Branches 491 491
==========================================
- Hits 20175 20174 -1
Misses 571 571
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/int-2
branch
2 times, most recently
from
888c403 to
fb32a2e
Compare
The checks are superceded by the checks in the Rust code, so replace the checks with documenting the preconditions so we don't need to worry about the functions failing anymore. Document some additional caveats discovered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks are superceded by the checks in the Rust code, so replace the checks with documenting the preconditions so we don't need to worry about the functions failing anymore.
Document some additional caveats discovered.