Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arithmetic/limbs internals: Clarify limbs < limbs checks. #2278

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

briansmith
Copy link
Owner

Reject empty or non-matching-length inputs. Refactor the internal API so that it is clearer that we're nearly always using this function to reject too-large inputs. This makes it easier to see that it is OK to return an error when previously we didn't.

This isn't intended to have any effect other than making the code easier to audit.

Reject empty or non-matching-length inputs. Refactor the internal
API so that it is clearer that we're nearly always using this
function to reject too-large inputs. This makes it easier to see
that it is OK to return an error when previously we didn't.

This isn't intended to have any effect other than making the code
easier to audit.
@briansmith briansmith self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.75%. Comparing base (1371308) to head (b50f143).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/arithmetic/bigint/modulusvalue.rs 50.00% 0 Missing and 2 partials ⚠️
src/limb.rs 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   96.75%   96.75%   -0.01%     
==========================================
  Files         171      171              
  Lines       20868    20875       +7     
  Branches      491      489       -2     
==========================================
+ Hits        20191    20197       +6     
- Misses        571      572       +1     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit 3c5946f into main Jan 23, 2025
167 of 169 checks passed
@briansmith briansmith deleted the b/limbs-lt-limbs branch January 23, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant