Update SamComparisonMetric.java and SamComparison.java to refactor ints to longs #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes integers to longs to prevent possible overflowing of counters in cases such as the forum topic below. https://gatk.broadinstitute.org/hc/en-us/community/posts/31913243796891-Negative-number-in-the-output-file-of-CompareSAMs
Updated methods for metrics.
gokalpcelik
changed the title
Additional refactors to fix possible problematic for loops for remaning reads.
Variables converted to longs to prevent casting longs to integers in tests.
lbergelson
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompareSAMs tool may cause overflows in metrics due to integer usage in variables.
This commit changes integers to longs to prevent possible overflowing of counters in cases such as the forum topic below.
https://gatk.broadinstitute.org/hc/en-us/community/posts/31913243796891-Negative-number-in-the-output-file-of-CompareSAMs