Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/validate docker compose #4213

Merged
merged 1 commit into from
Jul 3, 2024
Merged

lint/validate docker compose #4213

merged 1 commit into from
Jul 3, 2024

Conversation

bpblanken
Copy link
Collaborator

No description provided.

@bpblanken bpblanken marked this pull request as ready for review July 2, 2024 17:48
@bpblanken bpblanken changed the title lint docker compose lint/validate docker compose Jul 2, 2024
@bpblanken bpblanken requested review from hanars and jklugherz July 2, 2024 18:29
- uses: actions/checkout@v2
- uses: actions/checkout@v2
- name: Validate docker compose
run: docker-compose -f docker-compose.yml config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fail the workflow if the validation fails?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

bblanken@wmbbe-67c seqr % docker-compose -f docker-compose.yml config
validating /Users/bblanken/Desktop/code/seqr/docker-compose.yml: services.redis.healthcheck.retries must be a number
bblanken@wmbbe-67c seqr % echo $?
15

we get a non zero status validation failures.

@bpblanken bpblanken merged commit 27698f5 into dev Jul 3, 2024
8 checks passed
@bpblanken bpblanken deleted the benb/lint_docker_compose branch July 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants