do not use query_table for variant id queries #4518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the VLM I discovered that the approach we were using to look up variants in the hail backend, which is to create a key-table of locus-alleles and then use
query_table
to just read in the relevant rows, is actually substantially slower than reading in the table directly with the intervals set to the one base pair interval of the variant itself and then filtering for matching alleles. Testing on an GRCh37 lookup the time went from 32 seconds to 16 seconds, and GrCh38 is actually a bit slower the 37The
query_table
approach is still needed for SV lookup, as SV tables are not keyed by locus