Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Some small style tweaks. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbirch
Copy link

@sbirch sbirch commented Sep 7, 2013

This is a small visual tweak to the side-text.

screen shot 2013-09-07 at 5 46 53 pm
screen shot 2013-09-07 at 5 16 44 pm

@jpolitz
Copy link
Member

jpolitz commented Sep 8, 2013

Opinions @dbp , @shriram ?

The lighter border on the inline-examples seems like the nicest thing. I don't know if I care about the Georgia; and this commit doesn't make the Georgia change globally (e.g. on the course listing page), but the inline examples do look much nicer.

The white background I could go either way on.

@dbp
Copy link
Contributor

dbp commented Sep 8, 2013

I like the border and the background color. Don't care about the font.

@sbirch
Copy link
Author

sbirch commented Sep 9, 2013

Thanks, Joe.

re: the border, it's not so much the color as distinction between the text and the rest of the page -- making the column more obvious.

Sounds like Georgia is out :).

Another thing which I played with but couldn't figure out was to change the code font from "monospace" to one in particular. Courier and Courier New -- the default monospaces for most readers -- don't do a very good job at distinguishing things like L and 1 (which actually lead to some confusion for me on this assignment.) Others, such as the Adobe source family or Consolas explicitly account for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants