Update 16.9.1

[Zerwin]

Changes

Updates the app to 16.9.1

Checklist

• My change builds (Note: I used an base APK url from APK Mirror, the link will probably expire at some point.
• I tested my change
• I use the "bttv_" prefix for all resources I propose
• When adding a string I also added it to the bttv.Res.strings Enum and res/values/strings.xml (in mod) and res/values/public.xml (in disass)
• If my change is significant enough, I added it to the CHANGELOG.md under master
• I'll add myself and everyone else who contributed to this change to the contributors list using all-contributors (Can I even add myself ?)
• I license my changes according to the MIT License.

[welcome]

Thank you for opening this pull request ♥️ A maintainer should be by to give feedback soon.

[Zerwin]

@FoseFx Anything I should change about this ?

[FoseFx]

I am now done with a brief static review.

• Changes look largely good, thank you!
• Please revert the changes to the scripts and CI
• I do not see any modifications to the mod/twitch package, which is unlikely. Please run the ubi script, after installing ubi, and running buildsource once. You will likely see inconsistencies between the mocks in mod/twitch, and the actual methods in the apk.
• I have not built and tested your changes yet, please apply these changes first

[Zerwin]

How do I run the ubi script ? I found your ubi repo and build an ubi release, but if I run the script I just get

Found argument '--no-diff' which wasn't expected, or isn't valid in this context

If I remove --no-diff I then get

Found argument '/opt/bttv/baksmali-2.4.0.jar' which wasn't expected, or isn't valid in this context

Is there something else I need to do ?

[FoseFx]

How do I run the ubi script ? I found your ubi repo and build an ubi release, but if I run the script I just get

Found argument '--no-diff' which wasn't expected, or isn't valid in this context

If I remove --no-diff I then get

Found argument '/opt/bttv/baksmali-2.4.0.jar' which wasn't expected, or isn't valid in this context

Is there something else I need to do ?

Did you build the master or the v2 branch? The v2 branch is not ready to use.

[Zerwin]

Yep, that was it. I was on the v2 branch for some reason. Switched to master and now it ran. Do I need to manually fix the diffs or does the script do that automatically ?

[FoseFx]

No, the script is purely informational. Open up the mod project in Android Studio and rename / remove / create (new) classes / interfaces / methods of the twitch library. It hosts the shims, which are used in the app library (which is copied into the APK in buildsource). The goal here is not to perfectly replicate all internal twitch classes, but to have the minimal amount needed for the app to work.

Often classes / interfaces move places, sometimes they get split apart and sometimes they just get removed without replacement.

My advice is to use Android Studio's refactor tools (for example, it can move a class to a different package, and update all references).

[Zerwin]

What does this warning mean ?

WARN  ubi] not found in disass: tv/twitch/android/models/chat/AutoModMessageFlags.smali

I tried just removing the file in the mod/twitch folder but even after a buildsource and running the ubi script again it still prints the warning

[FoseFx]

What does this warning mean ?

That the AutoModMessageFlags class does not exist (in that package) anymore. Try to find it in the disass directory, it has moved somewhere else, or it got removed / renamed.

I tried just removing the file in the mod/twitch folder but even after a buildsource and running the ubi script again it still prints the warning

rm /tmp/bttv-* -rf && ./buildsource ... && ./ubi

should work

[Zerwin]

Okay, all done.

[Zerwin]

@FoseFx anything stopping this from merging now ?

[FoseFx]

I just tried it out, Nice work!

@all-contributors please add @Zerwin for code

[allcontributors]

@FoseFx

I've put up a pull request to add @Zerwin! 🎉

[welcome]

Thanks for your contribution to bttv-android! 🎉

[FoseFx]

Your change was just Released!

[Zerwin]

@FoseFx Do you think I could get permissions for handling Github issues ? Then I would comb through some of the existing ones to see if they still make sense with the new version.