fix: not using the K8s options in every case. (#125)

.gitignore

@@ -3,6 +3,7 @@
 *.user
 *.userosscache
 *.sln.docstates
+.vs/
 
 # Ci things
 node_modules/

src/DotnetKubernetesClient/DotnetKubernetesClient.csproj

@@ -26,4 +26,10 @@
         <PackageReference Include="KubernetesClient" Version="7.2.19" />
     </ItemGroup>
 
+    <ItemGroup>
+        <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
+            <_Parameter1>DotnetKubernetesClient.Test</_Parameter1>
+        </AssemblyAttribute>
+    </ItemGroup>
+
 </Project>

src/DotnetKubernetesClient/KubernetesClient.cs

@@ -89,7 +89,7 @@ public Task<string> GetCurrentNamespace(string downwardApiEnvName = "POD_NAMESPA
 
             if (result is JsonElement element)
             {
-                return element.Deserialize<TResource>();
+                return Deserialize<TResource>(element);
             }
 
             return null;
@@ -122,7 +122,7 @@ public async Task<IList<TResource>> List<TResource>(
 
         if (result is JsonElement element)
         {
-            var list = element.Deserialize<EntityList<TResource>>();
+            var list = Deserialize<EntityList<TResource>>(element);
             return list?.Items ?? throw new ArgumentException("Could not parse result");
         }
 
@@ -172,7 +172,7 @@ public async Task<TResource> Create<TResource>(TResource resource)
 
         if (result is JsonElement element)
         {
-            return element.Deserialize<TResource>() ?? throw new ArgumentException("Could not parse result");
+            return Deserialize<TResource>(element) ?? throw new ArgumentException("Could not parse result");
         }
 
         throw new ArgumentException("Could not parse result");
@@ -200,7 +200,7 @@ public async Task<TResource> Update<TResource>(TResource resource)
 
         if (result is JsonElement element)
         {
-            return element.Deserialize<TResource>() ?? throw new ArgumentException("Could not parse result");
+            return Deserialize<TResource>(element) ?? throw new ArgumentException("Could not parse result");
         }
 
         throw new ArgumentException("Could not parse result");
@@ -228,7 +228,7 @@ public async Task UpdateStatus<TResource>(TResource resource)
 
         if (result is JsonElement element)
         {
-            var parsed = element.Deserialize<TResource>() ?? throw new ArgumentException("Could not parse result");
+            var parsed = Deserialize<TResource>(element) ?? throw new ArgumentException("Could not parse result");
             resource.Metadata.ResourceVersion = parsed.Metadata.ResourceVersion;
             return;
         }
@@ -333,4 +333,17 @@ public Task<Watcher<TResource>> Watch<TResource>(
                 onError,
                 onClose));
     }
+
+    private static T Deserialize<T>(JsonElement element)
+    {
+        // If we were able to get the default options used by KubernetesJson,
+        // deserialize directly, it's going to be faster.
+        if (KubernetesJsonOptions.DefaultOptions is { } options)
+        {
+            element.Deserialize<T>(options);
+        }
+
+        // Else, fallback to the slower but more reliable method.
+        return KubernetesJson.Deserialize<T>(element.GetRawText());
+    }
 }

src/DotnetKubernetesClient/KubernetesJsonOptions.cs

@@ -0,0 +1,36 @@
+using System;
+using System.Reflection;
+using System.Text.Json;
+using k8s;
+
+#nullable enable
+
+namespace DotnetKubernetesClient
+{
+    internal static class KubernetesJsonOptions
+    {
+        private static readonly Lazy<JsonSerializerOptions?> Lazy = new(GetJsonSerializerOptions);
+
+        public static JsonSerializerOptions? DefaultOptions => Lazy.Value;
+
+        private static JsonSerializerOptions? GetJsonSerializerOptions()
+        {
+            try
+            {
+                // Get the default (and private) KubernetesJson options.
+                var fieldInfo = typeof(KubernetesJson).GetField("JsonSerializerOptions", BindingFlags.Static | BindingFlags.NonPublic);
+                if (fieldInfo != null
+                    && fieldInfo.GetValue(null) is JsonSerializerOptions options)
+                {
+                    return options;
+                }
+            }
+            catch
+            {
+                // Ignored
+            }
+
+            return null;
+        }
+    }
+}

tests/DotnetKubernetesClient.Test/KubernetesJsonOptions.Test.cs

@@ -0,0 +1,16 @@
+using FluentAssertions;
+using Xunit;
+
+namespace DotnetKubernetesClient.Test
+{
+    public class KubernetesJsonOptionsTest
+    {
+        [Fact]
+        public void DefaultOptions_should_not_return_null()
+        {
+            var result = KubernetesJsonOptions.DefaultOptions;
+
+            result.Should().NotBe(null);
+        }
+    }
+}