-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown processor and worker on init fail #7654
Shutdown processor and worker on init fail #7654
Conversation
Hey @pradovic, we need you to rebase your branch on top of latest develop to grab your CLA changes and pass the Also, we saw here there is a problem with one test. To fix it, you need to change the sleep time as I did here and here. I tried to push the changes myself, but for some reason they didn't get through. |
919cf50
to
8b28fd5
Compare
Thanks for the review! I rebased with |
ba052f6
to
db9bc60
Compare
@pradovic thank you for submitting the PR! I noticed that we needed to increase the sleep time on a test to make it work again. That makes me a little bit worried that there is a bug in our code which wasn't visible before. I think your code is absolutely fine, but I'll need to inspect how it affected that test before we can merge your PR. That will take a while. I'll get back to you as soon as I can |
@SanjoDeundiak Ok, thanks! let me know if I can help, I am trying to reproduce it locally but did not manage to do it. I will try to take a look as well. |
db9bc60
to
c2e041c
Compare
aff06ae
to
97310a9
Compare
97310a9
to
170504b
Compare
Current behavior
Worker and Processor do not shutdown if
initialize
function fails, per #7575.Proposed changes
If the
initialize
function fail, do not proceed to run loops, but instead shutdown self and stop ack the ctx.