Consolidate methods that read and write platform spec'd TOML #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
force-pushed
the
files-handler
branch
3 times, most recently
from
f07a204 to
b946759
Compare
natalieparellano
commented
Nov 1, 2023
| var Handler = &TOMLHandler{} | ||
|
|
||
| // TOMLHandler reads and writes lifecycle configuration files in TOML format. | ||
| type TOMLHandler struct{} |
There was a problem hiding this comment.
If we ever wanted the platform to be able to supply JSON or YAML files, we could implement an alternate handler with minimal other changes.
in platform/files package. Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
files-handler
branch
from
8f411f6 to
55f4521
Compare
natalieparellano
force-pushed
the
files-handler
branch
from
9d07a00 to
6ccda3e
Compare
natalieparellano
force-pushed
the
files-handler
branch
2 times, most recently
from
1c7af06 to
3781972
Compare
…esting This can help us diagnose weird failures in CI Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
files-handler
branch
from
3781972 to
bb2c7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in platform/files package.
With the exception of reading /config/metadata.toml in the launcher, as we want to avoid importing the buildpack package, and platform/files depends on it.
Summary
Release notes
Consolidates methods that read and write platform spec'd TOML in the platform/files package