Update to v1.6.26 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
* better summaries * [CI] Run CORE tests in GitHub Actions * fix * not required since we have a default value * use the right name * core super scaffolding tests * update the name * Link the core repo if we're using it * disable Circle workflow * maybe this * nope, just disabled the Circle webhook in GH
* [CI] Handle HIDE_THINGS differently in tests * linter * why is this test failing... * a little clean up
It seems that `factory_bot_rails` unexpectedly introduced a breaking change. thoughtbot/factory_bot#1602 For now I'm just going to avoid that version while we decide what to do about it: bullet-train-co/bullet_train-core#707
In order to get the CI workflow to run after we create the upgrade PR we need to create the PR using a PAT. (Weird GitHub Actions rules... 🤷)
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
* Silence erroneous backtrace lines from `device_test` Fixes bullet-train-co/bullet_train#1082 The `instance_eval` line in `device_test` adds 2 frames in the backtrace which test errors will erroneously point back to. So we silence those 2 frames. * Redirect `device_test` definitions to correct test file. All this is because Rails' `test` method uses `define_method`, which will report this file as the `source_location` and not the target test file where the test is actually defined. `define_method` cannot be passed the correct location, we must use `class_eval` with a source string of Ruby for that. But using a string means we can't refer to the block, like `define_method(name, &block)` would. So we inject a module that we define methods via `test` to pass the block to, then we override that via `class_eval` to point it to the correct location. * Add back TODO comment * Standard is wrong, gotta disable.
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Enable Action Model scaffolding with bin/super-scaffold * Remove colorize method from bin/super-scaffold * Require colorize and output error message as red in bin/super-scaffold
* Separate db lookup and link resolution * Separate db lookup and link resolution * Separate db look and link resolution in system tests
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Update Ruby to version 3.3.0 * Update nokogiri and bootsnap for compatibility with Ruby 3.3.0 (#1271) * Update Ruby to version 3.3.0 * Update nokogiri to 1.16.0 for Ruby 3.3.0 * Update bootsnap to v1.17.1 --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Jeremy Green <jagthedrummer@gmail.com> --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Gabriel Zayas <g-zayas@hotmail.com> Co-authored-by: Jeremy Green <jagthedrummer@gmail.com>
* Bump ruby to 3.3 for GitHub Actions * actually, just allow it to follow .ruby-version
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.