Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet Train Update: 1.9.0 #43

Merged
merged 37 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
c12492f
Update all Bundler dependencies (2024-10-31) (#1733)
depfu[bot] Oct 31, 2024
7f5ae3e
Update all Yarn dependencies (2024-11-01) (#1736)
depfu[bot] Nov 1, 2024
61d3ee0
Update all Bundler dependencies (2024-11-01) (#1735)
depfu[bot] Nov 1, 2024
7b68c24
Update all Bundler dependencies (2024-11-02) (#1740)
depfu[bot] Nov 2, 2024
744fece
Update all Yarn dependencies (2024-11-02) (#1741)
depfu[bot] Nov 2, 2024
474c1e1
Update all Bundler dependencies (2024-11-03) (#1742)
depfu[bot] Nov 3, 2024
6d4ca10
Update all Bundler dependencies (2024-11-05) (#1743)
depfu[bot] Nov 5, 2024
e183c95
Update all Bundler dependencies (2024-11-06) (#1744)
depfu[bot] Nov 6, 2024
4874a14
Update all Yarn dependencies (2024-11-06) (#1745)
depfu[bot] Nov 6, 2024
b561533
Update all Bundler dependencies (2024-11-07) (#1747)
depfu[bot] Nov 7, 2024
08c5f29
Update all Bundler dependencies (2024-11-08) (#1748)
depfu[bot] Nov 8, 2024
5469b3a
Update all Bundler dependencies (2024-11-09) (#1749)
depfu[bot] Nov 9, 2024
c355d45
Update all Yarn dependencies (2024-11-09) (#1750)
depfu[bot] Nov 9, 2024
7f2dbf1
Update all Yarn dependencies (2024-11-10) (#1751)
depfu[bot] Nov 10, 2024
aeeab9b
Update all Bundler dependencies (2024-11-12) (#1752)
depfu[bot] Nov 12, 2024
1a32536
Set `config.raise_on_missing_callback_actions = true` (#1725)
jagthedrummer Nov 12, 2024
8fcb955
Use `setup do` instead of `def setup` in tests (#1737)
jagthedrummer Nov 12, 2024
178252a
BT-Core version bump: - 1.8.2 (#1754)
jagthedrummer Nov 12, 2024
7f46276
Update all Bundler dependencies (2024-11-13) (#1755)
depfu[bot] Nov 13, 2024
cc7f11c
Update all Bundler dependencies (2024-11-14) (#1757)
depfu[bot] Nov 14, 2024
6eb3dea
Make it easier to use Cloudinary as a storage option for ActiveStorag…
jagthedrummer Nov 14, 2024
9ed59eb
BT-Core version bump: - 1.8.3 (#1758)
jagthedrummer Nov 14, 2024
1bf62f8
Update all Bundler dependencies (2024-11-15) (#1759)
depfu[bot] Nov 15, 2024
3dd80c6
BT-Core version bump: - 1.8.4 (#1760)
jagthedrummer Nov 15, 2024
826d787
Update all Bundler dependencies (2024-11-16) (#1761)
depfu[bot] Nov 16, 2024
e38b026
Update all Yarn dependencies (2024-11-16) (#1762)
depfu[bot] Nov 16, 2024
66d10cf
Update all Yarn dependencies (2024-11-17) (#1763)
depfu[bot] Nov 17, 2024
cc09216
Remove a monkey patch for ActionText::Content (#1764)
jagthedrummer Nov 18, 2024
ec22b55
Add script to check for image processing deps (#1689)
hopsoft Nov 18, 2024
b7291ae
Refactor check_image_dependencies.rb to not require both vips and Ima…
jagthedrummer Nov 18, 2024
7b19b09
BT-Core version bump: - 1.8.5 (#1766)
jagthedrummer Nov 18, 2024
9aba341
Update all Bundler dependencies (2024-11-19) (#1768)
depfu[bot] Nov 19, 2024
2ef1b1d
Upgrade pagy to version 8 (via `core`) (#1767)
jagthedrummer Nov 19, 2024
ac5c8dd
Update Ruby to version 3.3.6 (#1746)
depfu[bot] Nov 19, 2024
07774a0
Update Node.js to version 22.11.0 (#1734)
depfu[bot] Nov 19, 2024
54fa5a1
BT-Core version bump: - 1.9.0 (#1769)
jagthedrummer Nov 19, 2024
9493f1f
Merge tag 'v1.9.0'
jagthedrummer Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ aliases:
paths:
- node_modules
- &ruby_node_browsers_docker_image
- image: cimg/ruby:3.3.5-browsers
- image: cimg/ruby:3.3.6-browsers
environment:
PGHOST: localhost
PGUSER: untitled_application
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.18.0
22.11.0
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.5
3.3.6
5 changes: 1 addition & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,9 @@ end
# BULLET TRAIN GEMS
# This section is the list of Ruby gems included by default for Bullet Train.

# TODO: Remove this after updating the core gems to 1.7.21
gem "pagy", "< 7"

# We use a constant here so that we can ensure that all of the bullet_train-*
# packages are on the same version.
BULLET_TRAIN_VERSION = "1.8.1"
BULLET_TRAIN_VERSION = "1.9.0"

# Core packages.
gem "bullet_train", BULLET_TRAIN_VERSION
Expand Down
103 changes: 50 additions & 53 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ GEM
bootsnap (1.17.1)
msgpack (~> 1.2)
builder (3.2.4)
bullet_train (1.8.1)
bullet_train (1.9.0)
awesome_print
bullet_train-has_uuid
bullet_train-roles
Expand All @@ -145,7 +145,7 @@ GEM
microscope
nice_partials (~> 0.9)
omniauth
pagy (< 7)
pagy (~> 8)
possessive
premailer-rails
rails (>= 6.0.0)
Expand All @@ -155,72 +155,72 @@ GEM
unicode-emoji
valid_email
xxhash
bullet_train-api (1.8.1)
bullet_train-api (1.9.0)
bullet_train
bullet_train-super_scaffolding
colorizer
doorkeeper
factory_bot
jbuilder-schema (~> 2.6.6)
pagy (< 7)
pagy (~> 8)
pagy_cursor
rack-cors
rails (>= 6.0.0)
bullet_train-fields (1.8.1)
bullet_train-fields (1.9.0)
chronic
cloudinary
phonelib
rails (>= 6.0.0)
bullet_train-has_uuid (1.8.1)
bullet_train-has_uuid (1.9.0)
rails (>= 6.0.0)
bullet_train-incoming_webhooks (1.8.1)
bullet_train-incoming_webhooks (1.9.0)
bullet_train
bullet_train-api
bullet_train-super_scaffolding
rails (>= 6.0.0)
bullet_train-integrations (1.8.1)
bullet_train-integrations (1.9.0)
rails (>= 6.0.0)
bullet_train-integrations-stripe (1.8.1)
bullet_train-integrations-stripe (1.9.0)
omniauth
omniauth-rails_csrf_protection
omniauth-stripe-connect
rails (>= 6.0.0)
stripe
bullet_train-obfuscates_id (1.8.1)
bullet_train-obfuscates_id (1.9.0)
hashids
rails (>= 6.0.0)
bullet_train-outgoing_webhooks (1.8.1)
bullet_train-outgoing_webhooks (1.9.0)
public_suffix
rails (>= 6.0.0)
bullet_train-roles (1.8.1)
bullet_train-roles (1.9.0)
active_hash
activesupport
cancancan
bullet_train-routes (1.0.0)
rails (>= 6.0.0)
bullet_train-scope_questions (1.8.1)
bullet_train-scope_questions (1.9.0)
rails (>= 6.0.0)
bullet_train-scope_validator (1.8.1)
bullet_train-scope_validator (1.9.0)
rails
bullet_train-sortable (1.8.1)
bullet_train-sortable (1.9.0)
rails (>= 6.0.0)
bullet_train-super_load_and_authorize_resource (1.8.1)
bullet_train-super_load_and_authorize_resource (1.9.0)
cancancan
rails (>= 6.0.0)
bullet_train-super_scaffolding (1.8.1)
bullet_train-super_scaffolding (1.9.0)
colorizer
indefinite_article
masamune-ast (~> 2.0.2)
rails (>= 6.0.0)
bullet_train-themes (1.8.1)
bullet_train-themes (1.9.0)
bullet_train-fields
nice_partials (~> 0.9)
rails (>= 6.0.0)
bullet_train-themes-light (1.8.1)
bullet_train-themes-light (1.9.0)
bullet_train-themes-tailwind_css
masamune-ast (~> 2.0.2)
rails (>= 6.0.0)
bullet_train-themes-tailwind_css (1.8.1)
bullet_train-themes-tailwind_css (1.9.0)
bullet_train-themes
rails (>= 6.0.0)
cable_ready (5.0.5)
Expand Down Expand Up @@ -291,7 +291,7 @@ GEM
railties (~> 7.0)
rotp (~> 6.0)
docile (1.4.0)
doorkeeper (5.7.1)
doorkeeper (5.8.0)
railties (>= 5)
drb (2.2.0)
ruby2_keywords
Expand All @@ -311,16 +311,16 @@ GEM
factory_bot_rails (6.2.0)
factory_bot (~> 6.2.0)
railties (>= 5.0.0)
faraday (2.12.0)
faraday-net_http (>= 2.0, < 3.4)
faraday (2.12.1)
faraday-net_http (>= 2.0, < 3.5)
json
logger
faraday-follow_redirects (0.3.0)
faraday (>= 1, < 3)
faraday-multipart (1.0.4)
multipart-post (~> 2)
faraday-net_http (3.3.0)
net-http
faraday-net_http (3.4.0)
net-http (>= 0.5.0)
fastimage (2.3.1)
ffi (1.16.3)
figaro (1.2.0)
Expand Down Expand Up @@ -411,7 +411,7 @@ GEM
msgpack (1.7.2)
multi_xml (0.6.0)
multipart-post (2.4.1)
net-http (0.4.1)
net-http (0.5.0)
uri
net-imap (0.4.2)
date
Expand Down Expand Up @@ -449,8 +449,8 @@ GEM
omniauth (~> 1.3)
omniauth-oauth2 (~> 1.4)
orm_adapter (0.5.0)
ostruct (0.6.0)
pagy (6.4.2)
ostruct (0.6.1)
pagy (8.6.3)
pagy_cursor (0.8.0)
activerecord (>= 5)
pagy (>= 6, < 9)
Expand Down Expand Up @@ -645,7 +645,7 @@ GEM
stimulus-rails (1.3.0)
railties (>= 6.0.0)
stringio (3.0.8)
stripe (13.1.0)
stripe (13.1.2)
strscan (3.1.0)
terser (1.1.20)
execjs (>= 0.3.0, < 3)
Expand All @@ -661,10 +661,8 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.5.0)
unicode-emoji (3.8.0)
unicode-version (~> 1.0)
unicode-version (1.4.0)
uri (0.13.1)
unicode-emoji (4.0.4)
uri (1.0.2)
useragent (0.16.10)
valid_email (0.2.1)
activemodel
Expand Down Expand Up @@ -703,24 +701,24 @@ DEPENDENCIES
avo (>= 3.1.7)
aws-sdk-s3
bootsnap
bullet_train (= 1.8.1)
bullet_train-api (= 1.8.1)
bullet_train-fields (= 1.8.1)
bullet_train-has_uuid (= 1.8.1)
bullet_train-incoming_webhooks (= 1.8.1)
bullet_train-integrations (= 1.8.1)
bullet_train-integrations-stripe (= 1.8.1)
bullet_train-obfuscates_id (= 1.8.1)
bullet_train-outgoing_webhooks (= 1.8.1)
bullet_train-roles (= 1.8.1)
bullet_train-scope_questions (= 1.8.1)
bullet_train-scope_validator (= 1.8.1)
bullet_train-sortable (= 1.8.1)
bullet_train-super_load_and_authorize_resource (= 1.8.1)
bullet_train-super_scaffolding (= 1.8.1)
bullet_train-themes (= 1.8.1)
bullet_train-themes-light (= 1.8.1)
bullet_train-themes-tailwind_css (= 1.8.1)
bullet_train (= 1.9.0)
bullet_train-api (= 1.9.0)
bullet_train-fields (= 1.9.0)
bullet_train-has_uuid (= 1.9.0)
bullet_train-incoming_webhooks (= 1.9.0)
bullet_train-integrations (= 1.9.0)
bullet_train-integrations-stripe (= 1.9.0)
bullet_train-obfuscates_id (= 1.9.0)
bullet_train-outgoing_webhooks (= 1.9.0)
bullet_train-roles (= 1.9.0)
bullet_train-scope_questions (= 1.9.0)
bullet_train-scope_validator (= 1.9.0)
bullet_train-sortable (= 1.9.0)
bullet_train-super_load_and_authorize_resource (= 1.9.0)
bullet_train-super_scaffolding (= 1.9.0)
bullet_train-themes (= 1.9.0)
bullet_train-themes-light (= 1.9.0)
bullet_train-themes-tailwind_css (= 1.9.0)
capybara (~> 3.39)
capybara-email
capybara-lockstep
Expand All @@ -741,7 +739,6 @@ DEPENDENCIES
magic_test
minitest-reporters
minitest-retry
pagy (< 7)
pg (>= 0.18, < 2.0)
postmark-rails
pry
Expand All @@ -768,7 +765,7 @@ DEPENDENCIES
web-console

RUBY VERSION
ruby 3.3.5p100
ruby 3.3.6p108

BUNDLED WITH
2.4.10
5 changes: 1 addition & 4 deletions bin/setup
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,9 @@ require 'bundler/inline'
# and define some utility methods used by other scirpts.
require "#{__dir__}/setup-scripts/utils"



# path to your application root.
APP_ROOT = File.expand_path("..", __dir__)



FileUtils.chdir APP_ROOT do
# This script is a way to set up or update your development environment automatically.
# This script is idempotent, so that you can run it at any time and get an expectable outcome.
Expand All @@ -32,6 +28,7 @@ FileUtils.chdir APP_ROOT do
require "#{__dir__}/setup-scripts/check_postgres"
require "#{__dir__}/setup-scripts/check_redis"
require "#{__dir__}/setup-scripts/check_icu"
require "#{__dir__}/setup-scripts/check_image_dependencies" # Updated this line

require "#{__dir__}/setup-scripts/prepare_local_app"

Expand Down
47 changes: 47 additions & 0 deletions bin/setup-scripts/check_image_dependencies.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
#!/usr/bin/env ruby

require "#{__dir__}/utils"

announce_section "Checking Image Processing Dependencies"

def check_dependency(name, version_command)
puts "\nChecking #{name}..."
version_info = `#{version_command} 2>&1`

if $?.success?
version = version_info.split("\n").first
puts "#{name} is installed: #{version}".green
true
else
puts "#{name} is not installed or not found in PATH.".red
false
end
end

vips_installed = check_dependency("vips", "vips --version")
magick_installed = check_dependency("ImageMagick", "magick -version")

if vips_installed || magick_installed
# do nothing
else
puts " "
puts "--------------------------------------------".red
puts "We couldn't find either vips or ImageMagick.".red
puts " "
puts "To install vips:"
puts "Try `brew install vips` on macOS or `sudo apt-get install libvips` on Ubuntu."
puts " "
puts "To install ImageMagick:"
puts "Try `brew install imagemagick` on macOS or `sudo apt-get install imagemagick` on Ubuntu."
puts " "

continue_anyway = ask_boolean "Would you like to continue without any image processing dependencies?", "n"
if continue_anyway
puts "Continuing without image processing dependencies. This can prevent Rails scripts from running and cause problems with image processing.".yellow
else
puts "You've chosen not to continue without image processing dependencies. Goodbye.".red
exit
end
end

puts "\nImage processing dependency check completed.".green
12 changes: 7 additions & 5 deletions config/environments/development.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@
# if you want to change a default value specified here. Instead, simply re-specify the value in the section that
# follows this section.

# TODO: Eventually we should enable this by default. Currently enabling it causes problems.
# Related issue: https://github.com/bullet-train-co/bullet_train-core/issues/926
# Once that issue has been resolved we should remove this comment block and the following config line.
config.action_controller.raise_on_missing_callback_actions = false

# disable asset pipeline.
config.assets.enabled = false

Expand Down Expand Up @@ -119,6 +114,13 @@
# configuration right now, i'm making them the default here as well.
config.action_mailbox.ingress = :mailgun

# Rails defaults to :local in development. Set any of these ENV vars to use non-local options.
if (ENV["AWS_ACCESS_KEY_ID"] || ENV["BUCKETEER_AWS_ACCESS_KEY_ID"]).present?
config.active_storage.service = :amazon
elsif ENV["CLOUDINARY_URL"].present?
config.active_storage.service = :cloudinary
end

# ✅ YOUR APPLICATION'S CONFIGURATION
# If you need to customize your application's configuration, this is the place to do it. This helps avoid merge
# conflicts in the future when Rails or Bullet Train update their own default settings.
Expand Down
2 changes: 2 additions & 0 deletions config/environments/production.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@

if (ENV["AWS_ACCESS_KEY_ID"] || ENV["BUCKETEER_AWS_ACCESS_KEY_ID"]).present?
config.active_storage.service = :amazon
elsif ENV["CLOUDINARY_URL"].present?
config.active_storage.service = :cloudinary
else
puts "WARNING! : We didn't find an active_storage.service configured so we're falling back to the local store, but it's A VERY BAD IDEA to rely on it in production unless you know what you're doing."
config.active_storage.service = :local
Expand Down
5 changes: 0 additions & 5 deletions config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@
# if you want to change a default value specified here. Instead, simply re-specify the value in the section that
# follows this section.

# TODO: Eventually we should enable this by default. Currently enabling it causes problems.
# Related issue: https://github.com/bullet-train-co/bullet_train-core/issues/926
# Once that issue has been resolved we should remove this comment block and the following config line.
config.action_controller.raise_on_missing_callback_actions = false

# We only enable this for a specific test.
config.action_view.annotate_rendered_view_with_filenames = ENV["ENABLE_VIEW_ANNOTATION"] || false

Expand Down
Loading
Loading