Skip to content

Commit

Permalink
Upgrade pagy to version 8 (via core) (#1767)
Browse files Browse the repository at this point in the history
* Rely on the version of pagy specified by the core gems

* Fix the pagination test to match the new pagy default

* CI doesn't seem to find >...
  • Loading branch information
jagthedrummer authored Nov 19, 2024
1 parent 9aba341 commit 2ef1b1d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ end
# BULLET TRAIN GEMS
# This section is the list of Ruby gems included by default for Bullet Train.

# TODO: Remove this after updating the core gems to 1.7.21
gem "pagy", "< 7"

# We use a constant here so that we can ensure that all of the bullet_train-*
# packages are on the same version.
BULLET_TRAIN_VERSION = "1.8.5"
Expand Down
1 change: 0 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,6 @@ DEPENDENCIES
magic_test
minitest-reporters
minitest-retry
pagy (< 7)
pg (>= 0.18, < 2.0)
postmark-rails
pry
Expand Down
2 changes: 1 addition & 1 deletion test/system/pagination_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PaginationTest < ApplicationSystemTestCase
assert_text("Test 1")
refute_text("Test #{Pagy::DEFAULT[:items] + 1}")

click_on "Next"
click_on "2"
assert_text("Test #{Pagy::DEFAULT[:items] + 1}")
end
end

0 comments on commit 2ef1b1d

Please sign in to comment.