Minor fixes to JavaScript and README #102
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the changes I added here, the following two methods stood out to me:
keyDownFunction
keyUpFunction
There's some duplicate code here so I'd be glad to refactor some of it, but it looks like these methods aren't being used in the first place:
magic_test/app/views/magic_test/_listeners.html
Lines 2 to 3 in b086d2f
For that reason I won't worry about it too much now, but if we just want to get rid of these methods I can go head and delete them.