Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: linting with vacuum #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Dec 30, 2024

A guide showing a workflow for integrating Bump.sh and Vacuum.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit a73d1d7
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/6785267632579f000821e329
😎 Deploy Preview https://deploy-preview-313--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@philsturgeon
Copy link
Contributor Author

This is ready for review as far as content goes @ChristopheDujarric, but it's stuck waiting for a reply from Vacuum as the JUnit support is not complete enough to work with any of the GitHub Actions that handle "Test Results".

If we can get a new version released I'll make a decent demo of a change with errors being "annotated" by Vacuum in the files changed view, and get a summary on it, but I wanted to make sure you like the general direction of it whilst we wait.

Copy link
Contributor

@ChristopheDujarric ChristopheDujarric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide! It will definitely be useful, thanks Phil.

@daveshanley
Copy link

I will update vacuum to fix the issues!

@daveshanley
Copy link

I will update vacuum to fix the issues!

daveshanley/vacuum#599
https://github.com/daveshanley/vacuum/releases/tag/v0.15.1

vacuum should now push out the JUnit report correctly.

Thank you so much for doing this work, I am honored.

My only ask would be that I spell vacuum with a lowercase 'v'. This is specifically because thats how it's typed in the console. all my tools are lowercase.

Thank you once again!

@philsturgeon
Copy link
Contributor Author

My only ask would be that I spell vacuum with a lowercase 'v'. This is specifically because thats how it's typed in the console. all my tools are lowercase.

@daveshanley thank you for the fix, and of course we'll spell it however you like.

Getting the line number has been helpful, but if you can add the file="" too then we're cooking with biogas.

This is good enough to move the docs forward though, so @ChristopheDujarric please review at will. I'm "done"! :D

@ChristopheDujarric
Copy link
Contributor

Thanks a ton to both of you @philsturgeon and @daveshanley !

I'm very excited about this collaboration. We're fans of Vacuum and regularly advertise it to our customers. Having a guide dedicated to it made a lot of sense.

Looking forward to more stuff together!

We'll wait only for a week or so before merging and publishing this, as we want to give it the proper exposure in our editorial calendar.

@daveshanley
Copy link

My only ask would be that I spell vacuum with a lowercase 'v'. This is specifically because thats how it's typed in the console. all my tools are lowercase.

@daveshanley thank you for the fix, and of course we'll spell it however you like.

Getting the line number has been helpful, but if you can add the file="" too then we're cooking with biogas.

This is good enough to move the docs forward though, so @ChristopheDujarric please review at will. I'm "done"! :D

I can indeed addfile, coming up shortly!

@daveshanley
Copy link

Available in v0.15.2

https://github.com/daveshanley/vacuum/releases/tag/v0.15.2

@daveshanley
Copy link

daveshanley commented Jan 8, 2025

Thanks a ton to both of you @philsturgeon and @daveshanley !

I'm very excited about this collaboration. We're fans of Vacuum and regularly advertise it to our customers. Having a guide dedicated to it made a lot of sense.

Looking forward to more stuff together!

We'll wait only for a week or so before merging and publishing this, as we want to give it the proper exposure in our editorial calendar.

Great to hear it! thank you, looking forward to it too.

I use the train-travel spec as my default / boostrap spec in the openapi doctor. It's the first thing folks see!

https://pb33f.io/doctor/

Co-authored-by: Paul B. <paul+gh@bonaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants