-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: linting with vacuum #313
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is ready for review as far as content goes @ChristopheDujarric, but it's stuck waiting for a reply from Vacuum as the JUnit support is not complete enough to work with any of the GitHub Actions that handle "Test Results". If we can get a new version released I'll make a decent demo of a change with errors being "annotated" by Vacuum in the files changed view, and get a summary on it, but I wanted to make sure you like the general direction of it whilst we wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great guide! It will definitely be useful, thanks Phil.
I will update vacuum to fix the issues! |
daveshanley/vacuum#599
Thank you so much for doing this work, I am honored. My only ask would be that I spell Thank you once again! |
c57427f
to
78d61b5
Compare
@daveshanley thank you for the fix, and of course we'll spell it however you like. Getting the line number has been helpful, but if you can add the file="" too then we're cooking with biogas. This is good enough to move the docs forward though, so @ChristopheDujarric please review at will. I'm "done"! :D |
Thanks a ton to both of you @philsturgeon and @daveshanley ! I'm very excited about this collaboration. We're fans of Vacuum and regularly advertise it to our customers. Having a guide dedicated to it made a lot of sense. Looking forward to more stuff together! We'll wait only for a week or so before merging and publishing this, as we want to give it the proper exposure in our editorial calendar. |
I can indeed add |
Available in |
0a907a3
to
6f7e748
Compare
Great to hear it! thank you, looking forward to it too. I use the train-travel spec as my default / boostrap spec in the openapi doctor. It's the first thing folks see! |
Co-authored-by: Paul B. <paul+gh@bonaud.fr>
A guide showing a workflow for integrating Bump.sh and Vacuum.