Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c#: Add cli option to generate Result types #1115

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

jsturtevant
Copy link
Collaborator

Adds option to generate Result types instead of handling Results via Exceptions: #1042

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@alexcrichton alexcrichton requested a review from dicej January 8, 2025 15:44
@jsturtevant jsturtevant self-assigned this Jan 8, 2025
@jsturtevant jsturtevant requested review from silesmo and yowl January 8, 2025 16:39

/// Generates code for wit Result types instead of exceptions
#[cfg_attr(feature = "clap", arg(long))]
pub with_wit_results: bool,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open to name suggestions

Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks! Just a few whitespace and grammar nits.

crates/csharp/src/lib.rs Outdated Show resolved Hide resolved
tests/runtime/results/wasm_with_wit_results.cs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
crates/csharp/src/function.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@yowl yowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

crates/csharp/src/function.rs Outdated Show resolved Hide resolved
jsturtevant and others added 2 commits January 9, 2025 14:03
Co-authored-by: yowl <scott.waye@hubse.com>
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@dicej dicej added this pull request to the merge queue Jan 16, 2025
Merged via the queue into bytecodealliance:main with commit 0bb8697 Jan 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants