Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifting line functions #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lifting line functions #41

wants to merge 2 commits into from

Conversation

porter81nelson
Copy link

overloaded lifting_line_geometry and lifting_line_coefficients functions, updated documentation, and added unit tests.

rymanderson
rymanderson requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@rymanderson rymanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple of changes to make the user interface easier. Note that all these changes can be implemented without breaking previous syntax, merely by operator overloading for new arguments.

docs/src/guide.md Outdated Show resolved Hide resolved
src/geometry.jl Outdated Show resolved Hide resolved
src/geometry.jl Outdated Show resolved Hide resolved
src/nearfield.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymanderson rymanderson rymanderson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter81nelson @rymanderson