-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office #23
base: main
Are you sure you want to change the base?
Office #23
Conversation
worker, computer, phone, buttons
Thanks for merging my branch in! The only issue im facing is I cant buy sensors from the shop anymore. Nice job! |
Hey Dev, would you mind explaining or screenshotting your issue please? I can't replicate it. I can still buy and place sensors from the shop :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, restarting godot solved it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rafaela, just wanted to put in my review that I mentioned in the meeting. The bug happens on New Game. I ran through the tutorial then exit the Office scene. Then if you try to re-enter the office scene, the error happens. I think it has to do with not having a dialogue object for that instance, but still calling it because the office scene was clicked. I'd have to look into it but just having a default dialogue object per character might fix it for now?
Thank you Eddie. It was exactly what you said. Should be fixed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Glad to see you figured out adding a tutorial segment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Good job on the fix!
Hey guys! This is a combined pr between Dev and I. Here are a few things that we added, so that you can test them:
Let us know if you guys can find any bugs or UI issues we might have missed!