Remove references to cron

cadence-workflow · Jan 6, 2025 · a180073 · a180073
1 parent 001002d
commit a180073
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 18 deletions.
diff --git a/src/route-handlers/list-workflows/helpers/get-list-workflow-executions-query.ts b/src/route-handlers/list-workflows/helpers/get-list-workflow-executions-query.ts
@@ -2,15 +2,11 @@ import { type SortOrder } from '@/utils/sort-by';
 import { WORKFLOW_STATUSES } from '@/views/shared/workflow-status-tag/workflow-status-tag.constants';
 import type { WorkflowStatus } from '@/views/shared/workflow-status-tag/workflow-status-tag.types';
 
-import {
-  type ListWorkflowsCronValue,
-  type TimeColumn,
-} from '../list-workflows.types';
+import { type TimeColumn } from '../list-workflows.types';
 
 export default function getListWorkflowExecutionsQuery({
   search,
   workflowStatus,
-  cron,
   sortColumn,
   sortOrder,
   timeColumn,
@@ -19,7 +15,6 @@ export default function getListWorkflowExecutionsQuery({
 }: {
   search?: string;
   workflowStatus?: WorkflowStatus;
-  cron?: ListWorkflowsCronValue;
   sortColumn?: string;
   sortOrder?: SortOrder;
   timeColumn: TimeColumn;
@@ -45,10 +40,6 @@ export default function getListWorkflowExecutionsQuery({
     }
   }
 
-  if (cron) {
-    searchQueries.push(`IsCron = "${cron === 'CRON'}"`);
-  }
-
   if (timeRangeStart) {
     searchQueries.push(`${timeColumn} > "${timeRangeStart}"`);
   }

diff --git a/src/route-handlers/list-workflows/list-workflows.ts b/src/route-handlers/list-workflows/list-workflows.ts
@@ -46,7 +46,6 @@ export async function listWorkflows(
         : getListWorkflowExecutionsQuery({
             search: queryParams.search,
             workflowStatus: queryParams.status,
-            cron: queryParams.cron,
             sortColumn: queryParams.sortColumn,
             sortOrder: queryParams.sortOrder,
             timeColumn: queryParams.timeColumn,

diff --git a/src/route-handlers/list-workflows/list-workflows.types.ts b/src/route-handlers/list-workflows/list-workflows.types.ts
@@ -18,11 +18,6 @@ export type ListWorkflowsRequestQueryParams = z.input<
   typeof listWorkflowsQueryParamSchema
 >;
 
-export type ListWorkflowsCronValue = Exclude<
-  ListWorkflowsRequestQueryParams['cron'],
-  undefined
->;
-
 export type TimeColumn = ListWorkflowsRequestQueryParams['timeColumn'];
 
 export type ListWorkflowsResponse = {

diff --git a/src/route-handlers/list-workflows/schemas/list-workflows-query-params-schema.ts b/src/route-handlers/list-workflows/schemas/list-workflows-query-params-schema.ts
@@ -21,7 +21,6 @@ const listWorkflowsQueryParamSchema = z
         message: 'Invalid workflow status',
       })
       .optional(),
-    cron: z.enum(['CRON', 'NON_CRON']).optional(),
     timeColumn: z
       .enum(['StartTime', 'CloseTime'])
       .optional()

diff --git a/src/views/domain-workflows/domain-workflows-table/__tests__/domain-workflows-table.test.tsx b/src/views/domain-workflows/domain-workflows-table/__tests__/domain-workflows-table.test.tsx
@@ -211,7 +211,6 @@ function generateWorkflowPages(count: number): Array<ListWorkflowsResponse> {
         status: 'WORKFLOW_EXECUTION_CLOSE_STATUS_COMPLETED',
         startTime: 1684800000000,
         closeTime: count > 5 ? 1684886400000 : undefined,
-        isCron: false,
       })),
       nextPage: `${pageIndex + 1}`,
     })