New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PanelSection component to wrap error panels in tabs #777

Merged

Assem-Uber merged 3 commits into cadence-workflow:release/4.0.0 from adhityamamallan:panel-everywhere

Jan 6, 2025

Member

adhityamamallan commented Jan 3, 2025 •

edited

Loading

Summary

Use PanelSection to wrap error panels in all tab pages
Clean up unused code

Test plan

Ran locally.

Screenshot 2025-01-03 at 4 52 56 PM

Screenshot 2025-01-03 at 4 54 53 PM

Screenshot 2025-01-03 at 5 05 45 PM

Screenshot 2025-01-03 at 4 59 23 PM

adhityamamallan added 3 commits

January 3, 2025 16:27


          Use panel everywhere

8723d19


          Update panel

b92c1cd


          Add panel to workflow page

aa8d120

Assem-Uber approved these changes

View reviewed changes

Assem-Uber merged commit 059002e into cadence-workflow:release/4.0.0

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet