Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description and documentation link to modal #795

Merged

Conversation

adhityamamallan
Copy link
Member

Summary

  • Modify the config type to add fields for more detailed modal content, such as a more detailed explanation and a link to docs.
  • Set autoFocus to true for the Modal button so that it is focused when the modal is opened (the default behaviour is to focus on the first interactive element, which in this case is the link)

Test plan

Updated unit tests + ran locally.

Action modals:
Screenshot 2025-01-17 at 3 35 11 PM
Screenshot 2025-01-17 at 3 35 07 PM

Testing focus:
Screenshot 2025-01-17 at 3 04 17 PM

@Assem-Uber Assem-Uber merged commit 57889ad into cadence-workflow:release/4.0.0 Jan 20, 2025
1 check passed
@adhityamamallan adhityamamallan deleted the 4-action-desc branch January 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants