png2c: rewrite to GoLang for efficiency #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahirwpz
commented
Jan 24, 2021
tools/png2c/palette.go
Outdated
| StoreUnused bool | ||
| } | ||
|
|
||
| func ParseDoPaletteParams(paletteFlag string) (PaletteParams, error) { |
There was a problem hiding this comment.
@kjaroma Wouldn't it be better if you had only single parser for all parameters (i.e. palette, bitmap, etc.) ?
There was a problem hiding this comment.
@cahirwpz Maybe, I'll think about it, but I'm concerned about the complexity of returning union types from ParseParams function.
There was a problem hiding this comment.
@cahirwpz I have found the solution for parsing parameters. The flag package provides custom flag functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.