-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds inline qmk_info #63
base: main
Are you sure you want to change the base?
Conversation
Both changes look like pretty good improvements given the small diffs they require, I like it! Also thank you for the docs fixes. For encoders I have been thinking that they should be part of the I will give this a test later this week, but it would be nice to fix the lint issues (in the linked workflow, you can add a
I haven't worked with KMK at all, but if you think a parser for it is feasible I'd welcome any such contribution! Since they are py-based perhaps Python's built-in AST parsing utils can be used. |
67292d3
to
176962c
Compare
this PR now contains just the inline qmk_info; and fixes the lint issues |
Re your KMK comment: yes it seems straightforward to add a KMK extension which dumps a yaml keymap-drawer config file using simple reflection. I'll let you know when I have something working. KMK has a really nice interactive development workflow for keebs with MCUs supporting circuitpython. Much simpler than qmk toolchain imho |
hmm, i missed something with black? |
Thanks! I'll test this and tweak a few docs things before merging. Unfortunately life's been busy, but hoping to get to it soon. |
afbdb42
to
140ca43
Compare
Love it! I started writing a minimal keymap to SVG tool but ditched it when I found this.
I'm working on a little keymap exporter for kmk but here are a couple of little contributions as I figured out how
keymap
worked.Main thing is support for
layout: qmk_info
as inline version ofqmk_info_json
(just write same schema in yaml). I also added a minimal encoder style so thattype: encoder
renders a square key as a circle (50% border radius).There's an example that demonstrates both.