Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add booking and user creation source #18768

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Jan 20, 2025

What does this PR do?

Add booking and user creation source to be able to identify where a booking or a user creation was requested from (API V1, API V2, Webapp)

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • N/A I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Make bookings via Webapp, V1 and V2 and notice the creationSource in the DB reflect the same.
  • Make user via Webapp, V1 and V2 and notice the creationSource in the DB reflect the same.

Follow-up

I noticed that we're not running any tests in apps/api/v1/test/lib/bookings/_post.test.ts and I'll take care of that as a follow up, including test for the changes here. I have manually confirmed that v1 is working for this, so it should be okay as a follow up, gives me more time to fix that entire suite properly.

@github-actions github-actions bot added the ❗️ migrations contains migration files label Jan 20, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 20, 2025
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 11:22am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 11:22am

@alishaz-polymath alishaz-polymath marked this pull request as ready for review January 24, 2025 12:43
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request ❗️ migrations contains migration files ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants