Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for getting TURN creds #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

API for getting TURN creds #31

wants to merge 2 commits into from

Conversation

chemmagate
Copy link

No description provided.

})
.catch((err) => {

});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt this API make it very easy to abuse?
anyone could just go to the code of a supported app in browser and extract this line with all needed credentials. this could then be used anywhere while the app has to pay us?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lennart-csio No, This is api is not accessible by everyone.

We have a postgress flag for the appID called taasEnabled, This flag has to be true to obtain turnCredentials.

At the moment there is no way to set the flag without contacting us.

Copy link

@karthikbr82 karthikbr82 Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we can add "Contact us for enabling turn usage" in the documentation to prevent the confusion.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does say already "This is an on-demand feature, please contact sales@callstats.io for enabling this feature. "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikbr82 yes, i see. however, if there is an app that is taasEnabled and has this integrated, then any user can extract the line from the source code and use it himself without the app knowing

Copy link

@karthikbr82 karthikbr82 Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lennart-csio Exactly, Noting can be hidden in javascript. It was possible to do get the same when we were sending the credentials in recomenedConfig callback. Users can also extract turn credentials from authenticate response which we use for PCT. Or user can also write a peerconnection SHIM and extract iceServers from pcConfig.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lennart-csio @karthikbr82

Aren't the credentials rotating?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes they are

@vr000m
Copy link

vr000m commented Dec 2, 2020

@karthikbr82 there same question, why not merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants