only retrieve required latest records from historical stock data source #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this `ticker` name exists, access existing `ticker` collection, and proceed with the following logic: 1. for this ticker, retrieve the most recent `date` as document id 2. most recent date is defined as start date 3. current date is defined as end date 4. query historical stock price data store using this start and end date to retrieve stock price data to be inserted 5. Existing stock data in firestore is not required to be retrieved again
Qodana Community for PythonIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
2. renames ticker to symbol to match Openbb terminology 3. fix lint issues
2. Fixed circular reference with ProviderEnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this
tickername exists, access existingtickercollection, and proceed with the following logic:dateas document idTested in local