-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSRD-806: bring back things from the submodule task #57
Open
gurneyalex
wants to merge
19
commits into
master
Choose a base branch
from
task-submodule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimplement invoke submodule.init with click and the new framework
reimplement the invoke task with click
with the change back to submodules, we want the external sources to land in odoo/external-src
this command is different from otools-addons add-pending in that it does not change the requirements.txt
ivantodorovich
force-pushed
the
task-submodule
branch
from
December 12, 2024 20:02
408bafd
to
930b233
Compare
Hello @gurneyalex ! I wish I could've done more. It took me some time to get used to this tool again |
@gurneyalex I think this is ready I've also made some changes in: |
gurneyalex
force-pushed
the
task-submodule
branch
from
January 10, 2025 14:12
95509d7
to
94c6198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSRD-806
Depends on / related to: