Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sshkeys manager #1519

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Jan 13, 2025

Description

In preparation for intercepting SSH commands in the model proxy, I've created the business logic package sshkeys and corresponding manager struct to handle logic related to user SSH keys.

This PR builds on #1518

Partially fixes JUJU-7346

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@kian99 kian99 requested a review from a team as a code owner January 13, 2025 13:15
Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we're missing the mocks for the sshkey manager

@kian99
Copy link
Contributor Author

kian99 commented Jan 13, 2025

i think we're missing the mocks for the sshkey manager

Yeah and I need to wire it up still

@kian99 kian99 requested a review from SimoneDutto January 13, 2025 14:53
Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

@kian99 kian99 force-pushed the intercept-ssh-commands branch from 523bb39 to 6a3bab3 Compare January 14, 2025 08:03
Copy link
Collaborator

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please not embed in imported type in one of our own.

internal/jimm/sshkeys/types.go Show resolved Hide resolved
gossh "golang.org/x/crypto/ssh"
)

type PublicKey struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godoc, please

@kian99 kian99 merged commit 7a29162 into canonical:v3 Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants