-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sshkeys manager #1519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we're missing the mocks for the sshkey manager
Yeah and I need to wire it up still |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice nice
523bb39
to
6a3bab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please not embed in imported type in one of our own.
gossh "golang.org/x/crypto/ssh" | ||
) | ||
|
||
type PublicKey struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godoc, please
Description
In preparation for intercepting SSH commands in the model proxy, I've created the business logic package
sshkeys
and corresponding manager struct to handle logic related to user SSH keys.This PR builds on #1518
Partially fixes JUJU-7346
Engineering checklist