feat: support oidc webauthn sequencing mode #318
+140
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarcoMasile
approved these changes
Jan 15, 2025
| @@ -926,6 +927,7 @@ def _update_kratos_info_relation_data(self, event: RelationEvent) -> None: | |||
| schemas_configmap_name = self.schemas_configmap.name | |||
| configmaps_namespace = self.model.name | |||
| mfa_enabled = self.config.get("enforce_mfa") | |||
| oidc_webauthn_sequencing_enabled = self.config.get("enable_oidc_webauthn_sequencing") | |||
There was a problem hiding this comment.
would it be ok to provide a default value here?
Suggested change
| oidc_webauthn_sequencing_enabled = self.config.get("enable_oidc_webauthn_sequencing") | |
| oidc_webauthn_sequencing_enabled = self.config.get("enable_oidc_webauthn_sequencing", False) |
| @@ -529,6 +529,7 @@ def _render_conf_file(self) -> str: | |||
| enable_local_idp=self.config.get("enable_local_idp"), | |||
| enforce_mfa=self.config.get("enforce_mfa"), | |||
| enable_passwordless_login_method=self.config.get("enable_passwordless_login_method"), | |||
| enable_oidc_webauthn_sequencing=self.config.get("enable_oidc_webauthn_sequencing"), | |||
| @@ -8,7 +8,7 @@ identity: | |||
| - id: {{ schema_id }} | |||
| url: '{{ identity_schema }}' | |||
| {%- endfor %} | |||
| {%- if enable_local_idp and enforce_mfa %} | |||
| {%- if enable_oidc_webauthn_sequencing or enable_local_idp and enforce_mfa %} | |||
There was a problem hiding this comment.
suggestion: can you group the conditions here so they're easier to read and, more importantly, we make sure we don't make mistake
Comment on lines
+80
to
+84
| {%- if enable_oidc_webauthn_sequencing or enforce_mfa and enable_local_idp %} | ||
| lookup_secret: | ||
| enabled: True | ||
| {%- endif %} | ||
| {%- if enable_passwordless_login_method %} | ||
| {%- if enable_passwordless_login_method or enable_oidc_webauthn_sequencing %} |
wood-push-melon
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authentication factors sequencing:
reset-identity-mfaaction to includewebauthnenable_oidc_webauthn_sequencingkratos-infolib to include the mode - addsoidc_webauthn_sequencing_enabledto relation data.