Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh Prometheus scrape endpoint after IP change #451

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dariofaccin
Copy link
Contributor

Description

This PR aims to fix #438, an issue for which the unit address in the prometheus_scrape databag is not updated after IP change (e.g., pod restart).
The fix involves adding the update-status event to the list of bound events observed to re-set scrape job data.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Signed-off-by: Dario Faccin <dario.faccin@canonical.com>
@dariofaccin dariofaccin requested a review from a team as a code owner November 6, 2024 14:26
@dariofaccin dariofaccin merged commit 42d5405 into main Nov 6, 2024
30 checks passed
@dariofaccin dariofaccin deleted the TELCO-1438-fix-metrics-ip-update branch November 6, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics not gathered after ip change
2 participants