Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename SD-Core charms by adding -k8s as a suffix #58

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 5, 2023

Description

Add -k8s as a suffix in both github and Charmhub name to follow TE042.

  • Create new fiveg_n2 library
  • Pin macaroonbakery to 1.3.2 which installed by juju client indirectly through pytest_operator.
    - The next protobuf version 4.21.0 has the breaking changes with the existing code
    - https://protobuf.dev/news/2022-05-06/#python-updates

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from a team as a code owner December 5, 2023 14:13
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of reminders:

Before merging this:

  • Register sdcore-amf-k8s in Charmhub. Note that it's possible that the release to this new charmhub page does not work automatically. The first upload is sometimes tricky and has to be done manually. It's also possible that the current keys for the upload don't work with the new charm you'll have registered.

After merging this:

  • Update the Github project name to sdcore-amf-k8s-operator

After the charm is published and released

  • Change the ownership from yours to the Telco team.

@gatici gatici changed the title Rename SD-Core charms by adding -k8s as a suffix feat: Rename SD-Core charms by adding -k8s as a suffix Dec 5, 2023
@gatici gatici changed the title feat: Rename SD-Core charms by adding -k8s as a suffix chore: Rename SD-Core charms by adding -k8s as a suffix Dec 5, 2023
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gruyaume
Copy link
Contributor

gruyaume commented Dec 7, 2023

@gatici Here we're still using the lib coming from charms/sdcore_nrf instead of the new charm from the NRF. You should also a new NRF lib in the NRF charm, release the NRF charm. Then here we'll need to pull it here and everywhere else that this lib is used.

The AMF also publishes a lib so you'll need to do the same here as well.

@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from 1958cb5 to 3c0ac93 Compare December 7, 2023 20:07
@gatici
Copy link
Contributor Author

gatici commented Dec 7, 2023

@gatici Here we're still using the lib coming from charms/sdcore_nrf instead of the new charm from the NRF. You should also a new NRF lib in the NRF charm, release the NRF charm. Then here we'll need to pull it here and everywhere else that this lib is used.

The AMF also publishes a lib so you'll need to do the same here as well.

fiveg_n2 library is created and fiveg_nrf is updated here after creating in nrf charm.

@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from 3c0ac93 to 5cdbbec Compare December 8, 2023 06:51
Update fiveg_nrf library
Pin macaroonbakery to 1.3.2
The next protobuf version 4.21.0 has the breaking changes with the existing code
https://protobuf.dev/news/2022-05-06/#python-updates

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from 5cdbbec to d57cede Compare December 8, 2023 13:07
@gatici gatici merged commit 5121cc7 into main Dec 11, 2023
12 checks passed
@gatici gatici deleted the TELCO-921-follow-charm-naming-convention branch December 11, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants