-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename SD-Core charms by adding -k8s as a suffix #58
Conversation
Signed-off-by: gatici <gulsum.atici@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of reminders:
Before merging this:
- Register
sdcore-amf-k8s
in Charmhub. Note that it's possible that the release to this new charmhub page does not work automatically. The first upload is sometimes tricky and has to be done manually. It's also possible that the current keys for the upload don't work with the new charm you'll have registered.
After merging this:
- Update the Github project name to
sdcore-amf-k8s-operator
After the charm is published and released
- Change the ownership from yours to the Telco team.
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici Here we're still using the lib coming from The AMF also publishes a lib so you'll need to do the same here as well. |
1958cb5
to
3c0ac93
Compare
fiveg_n2 library is created and fiveg_nrf is updated here after creating in nrf charm. |
3c0ac93
to
5cdbbec
Compare
Update fiveg_nrf library Pin macaroonbakery to 1.3.2 The next protobuf version 4.21.0 has the breaking changes with the existing code https://protobuf.dev/news/2022-05-06/#python-updates Signed-off-by: gatici <gulsum.atici@canonical.com>
5cdbbec
to
d57cede
Compare
Description
Add -k8s as a suffix in both github and Charmhub name to follow TE042.
- The next protobuf version 4.21.0 has the breaking changes with the existing code
- https://protobuf.dev/news/2022-05-06/#python-updates
Checklist: