Adds input validation to device group creation

canonical · Dec 7, 2023 · 0f9f432 · 0f9f432
1 parent 1e1c430
commit 0f9f432
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/pages/api/device-group/[name].ts b/pages/api/device-group/[name].ts
@@ -87,7 +87,8 @@ async function handleGET(req: NextApiRequest, res: NextApiResponse) {
     });
 
     if (!response.ok) {
-      throw new Error(`Error getting device group. Error code: ${response.status}`);
+      res.status(response.status).json({ error: "Error retrieving network slice." });
+      return;
     }
 
     const data = await response.json();

diff --git a/pages/api/network-slice/[name].ts b/pages/api/network-slice/[name].ts
@@ -63,7 +63,7 @@ async function handleGET(req: NextApiRequest, res: NextApiResponse) {
 
 
     if (!response.ok) {
-      res.status(response.status).json({ error: "Invalid name provided." });
+      res.status(response.status).json({ error: "Error retrieving network slice." });
       return;
     }
 

diff --git a/utils/createDeviceGroup.tsx b/utils/createDeviceGroup.tsx
@@ -41,6 +41,17 @@ export const createDeviceGroup = async ({
   };
 
   try {
+    const checkResponse = await fetch(`/api/device-group/${name}`, {
+      method: "GET",
+      headers: {
+        "Content-Type": "application/json",
+      },
+    });
+
+    if (checkResponse.ok) {
+      throw new Error("Device group already exists");
+    }
+
     const response = await fetch(`/api/device-group/${name}`, {
       method: "POST",
       headers: {
-Original file line number
+Diff line change
@@ Expand Up @@
         if (!response.ok) {
-          res.status(response.status).json({ error: "Invalid name provided." });
+          res.status(response.status).json({ error: "Error retrieving network slice." });
           return;
         }
@@ Expand Down @@