Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Subscriber page crashes when webui returns nil #193

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

gruyaume
Copy link
Contributor

Description

There is an issue where the subscribers page crashes when webui returns nil. This PR makes it so that when that occurs, an empty list is returned instead making the page render correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner November 28, 2023 21:32
@gruyaume gruyaume marked this pull request as draft November 28, 2023 21:34
@gatici gatici changed the title Fix: Subscriber page crashes when webui returns nil fix: Subscriber page crashes when webui returns nil Nov 29, 2023
@gruyaume gruyaume marked this pull request as ready for review November 29, 2023 17:13
@gruyaume gruyaume merged commit f2e60c3 into main Nov 29, 2023
8 of 9 checks passed
@gruyaume gruyaume deleted the dev-subscriberbug branch November 29, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants