Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Treats mcc and mnc as text instead of numbers #203

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

gruyaume
Copy link
Contributor

Description

The network slice creation modal use to consider MCC's and MNC's starting with zero's as invalid. This PR fixes this problem by considering those entries as text instead of numbers.

Fixes #196

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner November 30, 2023 22:27
@patriciareinoso
Copy link
Contributor

i don't see any validation about the characters that can be used over the mcc and mnc. What happens if we make mcc=abc ?

@gruyaume
Copy link
Contributor Author

gruyaume commented Dec 2, 2023

i don't see any validation about the characters that can be used over the mcc and mnc. What happens if we make mcc=abc ?

Agreed, fixed

@gruyaume gruyaume merged commit 1e06347 into main Dec 4, 2023
8 checks passed
@gruyaume gruyaume deleted the dev-mccvalid branch December 4, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Country Code starting with zeros are not accepted in the network slice creation modal
3 participants