Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webui backend to rock #621

Merged
merged 10 commits into from
Aug 7, 2024
Merged

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Jul 4, 2024

Description

The Rock container image for the NMS should contain both the Next.JS frontend (NMS) and backend components (WebUI).

This PR:

  • Build the frontend
  • Copy the static files over to the webconsole/ui/frontend_files directory
  • Build the backend with the ui go build tag.

Remove integration tests: webui is the service that runs on the rock. We cannot test that we have access to the UI as before because, in order to get the webui up and running it needs to connect to mongoDB. If the connection fails, an exception is raised.

This PR depends on:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

rockcraft.yaml Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
@patriciareinoso patriciareinoso force-pushed the TELCO-1150-add-backend-to-rock branch from 319a029 to 710d919 Compare August 2, 2024 06:52
@patriciareinoso patriciareinoso marked this pull request as ready for review August 2, 2024 08:37
@patriciareinoso patriciareinoso requested a review from a team as a code owner August 2, 2024 08:37
rockcraft.yaml Outdated Show resolved Hide resolved
.github/workflows/integration_tests.yaml Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@patriciareinoso patriciareinoso merged commit 7e63f18 into main Aug 7, 2024
16 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1150-add-backend-to-rock branch August 7, 2024 12:27
gatici added a commit to canonical/sdcore-nms-k8s-operator that referenced this pull request Sep 24, 2024
…s not include them paths for them after this change canonical/sdcore-nms#621.

Signed-off-by: gatici <gulsum.atici@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants