Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove useEffects #707

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: remove useEffects #707

wants to merge 3 commits into from

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Jan 15, 2025 •
edited
Loading

Description

This PR reduces the usage of useEffect in the NMS.
useEffect is removed from 4 different places and useQuery is used.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

gatici added 2 commits January 15, 2025 17:21
@gatici
chore: remove useEffects
8972dcb 
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici
fix:typo
379639e 
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from a team as a code owner January 15, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatici @ghislainbourgeois