Code

Rework ordering filter#1118

Code

Open

earshinov wants to merge 10 commits intocarltongibson:maincarltongibson/django-filter:mainfrom earshinov:rework-ordering-filterearshinov/django-filter:rework-ordering-filterCopy head branch name to clipboard

+580-65

Commits

Commits on May 24, 2020

• Add OrderingFilterTests.test_ordering_with_nulls to lock down ordering behavior regarding nulls

  earshinov

  committed
  4c5e00e

  Copy full SHA for 4c5e00e

• Initial push for reworked OrderingFilter

  Show description for 5d781a2
  earshinov

  committed
  5d781a2

  Copy full SHA for 5d781a2

• Resolve errors reported by lint and isort

  earshinov

  committed
  db1986f

  Copy full SHA for db1986f

• Run isort

  earshinov

  committed
  e21ba2d

  Copy full SHA for e21ba2d

• Fix tests under Django 1.11 by defining custom F.__eq__ and OrderBy.__eq__ operators

  earshinov

  committed
  25e130c

  Copy full SHA for 25e130c

• Cover the case when ordering descriptor is specified as a list of model fields

  earshinov

  committed
  36231d5

  Copy full SHA for 36231d5

• Correct a comment

  earshinov

  committed
  56f81cd

  Copy full SHA for 56f81cd

• In the updated OrderingFilter class, rename _params to params to match the style of existing code

  earshinov

  committed
  964fa26

  Copy full SHA for 964fa26

• Remove if True which was probably used for debugging

  earshinov

  committed
  ee0e6ba

  Copy full SHA for ee0e6ba

• Use a nullable DateTime model field to test OrderingFilter's handling of nulls

  earshinov

  committed
  e192249

  Copy full SHA for e192249