feat: add max recursion depth param to avoid hydration stack overflow #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartianGreed
force-pushed
the
feat/hydration-max-depth
branch
from
0f7b9b7 to
cc73ad4
Compare
glihm
requested changes
Dec 4, 2024
crates/parser/src/tokens/mod.rs
Outdated
| pub fn hydrate( | ||
| token: Self, | ||
| filtered: &HashMap<String, Token>, | ||
| _recursion_max_depth: usize, |
There was a problem hiding this comment.
Why _? If they are used, we shouldn't add this leading _.
Comment on lines
+1145
to
+1146
| #[test] | ||
| fn test_collect_tokens() { |
There was a problem hiding this comment.
Would you mind moving this test out of this file since it's becoming huge? in this case having a parser_test.rs for now should suffice.
There was a problem hiding this comment.
Or use include_str! and put the Sierra file inside a /test_data folder.
MartianGreed
force-pushed
the
feat/hydration-max-depth
branch
from
cc73ad4 to
de92e0f
Compare
glihm
changed the title
glihm
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… stack overflow