Rebase, and comments #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rknet-strange#44) * feat: add the manual registration of messages gated under messaging_test feature * fix: remove unused files * fix: ensure the first nonce is 0 and use other value for sealed messages * fix: directly use the appchain message type instead of nonce magic value * tests: add messaging-test test * fix: run scarb fmt * ci: call snforge using scarb interface * tests: fix nonce since it starts to 0 now * fix: run scarb fmt * fix(bindings): regenerate bindings with latest version
It's a better convention to use Span when accepting inputs from an external call (contract entrypoint), since the memory is not accessible, hence the array can't be modify anyway.
|
Had been merged from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, uses new logic for messages, adds comments and was tested on production with saya,