Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BlockValidator to ProposedBlockValidator #4394

Closed

Conversation

Fraser999
Copy link
Contributor

This PR is a simple rename of the given component and related variables/config options.

Note that the name of memory metrics for the component was left unchanged as "mem_block_validator" in order to avoid breaking the generated metrics API. This can be updated in 2.0.

Closes #4309.

Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cspramit
Copy link
Contributor

@Fraser999 , why is this currently marked 'do not merge' please?

@Fraser999
Copy link
Contributor Author

@cspramit It's since dev was frozen until we cut the release branch for node 1.5.4.

@Fraser999 Fraser999 closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename BlockValidator to ProposedBlockValidator
3 participants