Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 1.6 release branch into dev #4662

Closed
wants to merge 1,198 commits into from
Closed

Merge 1.6 release branch into dev #4662

wants to merge 1,198 commits into from

Conversation

marc-casperlabs
Copy link
Contributor

This is a successor of #4271. Closes #3941.

Contains multiple larger changesets:

  • The juliet crate and its integration into the node, forming the new base networking for the 1.6 release.
  • ConMan replacing the previous connection management of the node.
  • EE changes:
    • Prunes withdraw keys post migration
    • Wasmi is updated to 0.13.2
    • Pruning is exposed as a new transform and could be found in the journal
    • Better error messages when trying to run Wasm with non-MVP opcodes
  • Smaller fixes, expanded test coverage (e.g. around metrics) and utility features and refactorings have been added.
  • Rate limiting for log messages

While the review may seem a little daunting, if focusing on a single aspect at once (EE, juliet, integration of juliet and misc changes) should make it more manageable.

marc-casperlabs and others added 30 commits February 19, 2024 16:21
@marc-casperlabs
Add ActiveRoute type
4923dc9
@marc-casperlabs
Use ActiveRoute for both incoming and outgoing connections
1de50e0
@marc-casperlabs
Remove IncomingHandler in favor of single handling function
10f74f6
@marc-casperlabs
Cleanup logging around active routes
3bb8617
@marc-casperlabs
More logging cleanup
5239425
@marc-casperlabs
Fix issue with duplicate field recording on Span
e0121e1
@marc-casperlabs
Fix typo in comment
8fa4de1
@marc-casperlabs
Rewrite once_per as rate_limited module, with better performance …
8905f1c 
…and more control over rates
@marc-casperlabs
Add external learn_addr function for ConMan
8d65b05
@marc-casperlabs
Graft ConMan onto networking component
f92cd2f
@marc-casperlabs
Add connection manager ban support
d9eacbe
@marc-casperlabs
Get node in a roughly compiling state again
11f0314
@marc-casperlabs
Remove tarpit feature and other unused parts of the networkin context
a9c9d1b
@marc-casperlabs
Cleanup code handling known addresses
cb969dd
@marc-casperlabs
Allow reading of ConManState
7f9da2e
@marc-casperlabs
Restore message sending functionality
0ecb159
@marc-casperlabs
When broadcasting, only serialize message once
b1c890d
@hoffmannjan
fixed warnings
6723271
@hoffmannjan
code formatted
b9c6596
@marc-casperlabs
Restore functionality of has_sufficient_fully_connected_peers as `h…
580fdd6 
…as_sufficient_fully_connected_peers`
@marc-casperlabs
Restore functionality of fully_connected_peers_random as `connected…
91862e9 
…_peers_random`
@marc-casperlabs
Restore gossiping to the extent it was before
c326865
@marc-casperlabs
Restore peers function, changing its signature to return `SocketAdd…
f98d4ba 
…r` instances at the same time
@marc-casperlabs
Sketch new protocol handler in transport module
d829d4f
@marc-casperlabs
Remove reactor event from networking context
9c0501a
@marc-casperlabs
Use () as the payload for the encoded handshake
0d78d42
@marc-casperlabs
Move handshake negotiation into handshake module
1cb7776
@marc-casperlabs
Put creation of ConnectionId into handshake itself
a69fe38
@marc-casperlabs
Improve cryptographic security of ConnectionId
7c8d620
@marc-casperlabs
Use different reconnection delay based on how long we were serving a …
d7124cb 
…peer
@marc-casperlabs
Copy link
Contributor Author

bors try

casperlabs-bors-ng bot added a commit that referenced this pull request Apr 12, 2024
@casperlabs-bors-ng
Try #4662:
8261a54
@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

try

Build succeeded:

EdHastingsCasperAssociation
EdHastingsCasperAssociation requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this to avoid accidental merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdHastingsCasperAssociation EdHastingsCasperAssociation EdHastingsCasperAssociation requested changes

@fizyk20 fizyk20 Awaiting requested review from fizyk20

@darthsiroftardis darthsiroftardis Awaiting requested review from darthsiroftardis

@alsrdn alsrdn Awaiting requested review from alsrdn

@rafal-ch rafal-ch Awaiting requested review from rafal-ch

@jacek-casper jacek-casper Awaiting requested review from jacek-casper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge feat-1.6 to dev
4 participants
@marc-casperlabs @EdHastingsCasperAssociation @hoffmannjan @igor-casper