Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IncentivizedPolymerEscrow with Polymer universal channel IBC middleware #12

Merged
merged 9 commits into from
Mar 1, 2024

Conversation

alfredo-stonk
Copy link

No description provided.

@reednaa reednaa mentioned this pull request Dec 13, 2023
@alfredo-stonk alfredo-stonk marked this pull request as ready for review December 13, 2023 22:28
src/apps/polymer/IncentivizedPolymerEscrow.sol Outdated Show resolved Hide resolved
src/apps/polymer/IncentivizedPolymerEscrow.sol Outdated Show resolved Hide resolved
src/apps/polymer/IncentivizedPolymerEscrow.sol Outdated Show resolved Hide resolved
src/apps/polymer/IncentivizedPolymerEscrow.sol Outdated Show resolved Hide resolved
Copy link
Member

@reednaa reednaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good.

@alfredo-stonk alfredo-stonk force-pushed the polymer-universal-channel branch from 91edf6f to cae1e82 Compare February 27, 2024 22:27
@alfredo-stonk
Copy link
Author

@reednaa Most recent changes made:

  • updated our SC dep (submodule) to latest stable version v1.0
  • rebased this PR branch off main
  • changed IncentivizedPolymerEscrow so it inherits IncentivizedMessageEscrow

@reednaa reednaa force-pushed the polymer-universal-channel branch 2 times, most recently from 48ddd55 to 10e471d Compare February 29, 2024 14:18
@reednaa reednaa force-pushed the polymer-universal-channel branch from 10e471d to 9cd7c64 Compare March 1, 2024 12:30
@reednaa reednaa merged commit 9a8cd4b into main Mar 1, 2024
1 check passed
@reednaa reednaa deleted the polymer-universal-channel branch April 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants